serverutils: redirect the implicit ApplicationLayerInterface properly#110001
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Sep 11, 2023
Merged
serverutils: redirect the implicit ApplicationLayerInterface properly#110001craig[bot] merged 2 commits intocockroachdb:masterfrom
ApplicationLayerInterface properly#110001craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
This was referenced Sep 5, 2023
Closed
a2e6173 to
08dc3d4
Compare
08dc3d4 to
8c1a502
Compare
Contributor
Author
|
The remaining failure in //pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl is not specific to this PR and discussed here. |
8c1a502 to
9c663c6
Compare
Member
|
Nice, very happy to see this! LGTM, but I'll defer to others for approval. |
9c663c6 to
073cf38
Compare
craig bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
110008: *: improve some tests r=stevendanna,yuzefovich,abargainier a=knz This PR contains the test improvements prerequisite to #110001. Epic: CRDB-18499 Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Release note: None
Prior to this patch, the *implicit* `ApplicationLayerInterface` implementation inside `TestServerInterface` was redirecting to `SystemLayer()`. This was confusing, likely the source of bugs, and resulted in insufficient test coverage. This commit fixes it. Release note: None
073cf38 to
e648b81
Compare
Contributor
Author
|
rebased; PTAL |
stevendanna
approved these changes
Sep 11, 2023
Collaborator
stevendanna
left a comment
There was a problem hiding this comment.
Reminder to remove the wip commit before merge.
Contributor
Author
Done. |
e648b81 to
46009af
Compare
Contributor
Author
|
TFYR! bors r=stevendanna |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All commits but the last 3 are from #110008.
Epic: CRDB-18499
Prior to this patch, the implicit
ApplicationLayerInterfaceimplementation inside
TestServerInterfacewas redirecting toSystemLayer(). This was confusing, likely the source of bugs, andresulted in insufficient test coverage.
This commit fixes it.
followup issues identified thanks to this work:
can_view_node_info#110023