ui: all xhr paths from db console are now relative#109694
ui: all xhr paths from db console are now relative#109694craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
54be61f to
d57b907
Compare
Santamaura
left a comment
There was a problem hiding this comment.
Reviewed 17 of 21 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @kpatron-cockroachlabs)
maryliag
left a comment
There was a problem hiding this comment.
Can you confirm all pages are working with these changes? With a loom or something like that
Reviewed 17 of 21 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:
This commit removes all prefix `/` characters from request paths in the DB Console and Cluster UI codebases. This ensures that if the DB Console is proxied at a subpath the requests continue to work as expected and are relative to the correct base path. Resolves: cockroachdb/helm-charts#228 Resolves: cockroachdb#91429 Epic: None Release note (ops change, ui change): The DB Console now constructs client-side requests using relative URLs instead of absolute ones. This enables proxying of the DB Console at arbitrary subpaths.
d57b907 to
727d847
Compare
zachlite
left a comment
There was a problem hiding this comment.
Looks great. Appreciate the loom.
Reviewable status:
j82w
left a comment
There was a problem hiding this comment.
Reviewable status:
|
@dhartunian There's been a request for a v22.x backport here: https://github.com/cockroachlabs/support/issues/2504 Just letting you know for awareness. I'll leave the backport strategy up to you, of course 🙂 |
|
TFTRs bors r=santamaura,zachlite,j82w |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 727d847 to blathers/backport-release-22.2-109694: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error creating merge commit from 727d847 to blathers/backport-release-23.1-109694: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This commit removes all prefix
/characters from request paths in the DB Console and Cluster UI codebases. This ensures that if the DB Console is proxied at a subpath the requests continue to work as expected and are relative to the correct base path.Resolves: cockroachdb/helm-charts#228
Resolves: #91429
Epic CRDB-21265
Release note (ops change, ui change): The DB Console now constructs client-side requests using relative URLs instead of absolute ones. This enables proxying of the DB Console at arbitrary subpaths.