changefeedccl: assert increasing resolved message timestamps in validators#108861
Open
jayshrivastava wants to merge 2 commits intocockroachdb:masterfrom
Open
changefeedccl: assert increasing resolved message timestamps in validators#108861jayshrivastava wants to merge 2 commits intocockroachdb:masterfrom
jayshrivastava wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
2a2eb38 to
963dd71
Compare
The `NoteResolved` API on the `cdctest.Validator` requires that the passed resolved timestamp is the resolved timetsamp / frontier for the whole set of spans being tracked by the validator. Previously, tests would submit resolved timestamps for subsets of spans at a time, which is incorrect. This would not cause tests to fail because the order validator does not assert that resolved timetsamps monotonically increase (tracked by cockroachdb#108872). This change updates these tests to submit resolved timestamps for the overall set of spans being tracked. After this change, fixing the ordering validator in (cockroachdb#108872) will not cause these tests to fail. Release note: None Epic: None
…ators Previously, no validator in the `cdctest` package would assert that resolved messages increase monotonically. This is an important ordering guarantee that changefeeds provide. This change updates the `orderValidator` to assert this. Release note: None Epic: None Fixes: cockroachdb#108872
963dd71 to
3366cfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
streamingccl: fix incorrect usages of cdctest.Validator
The
NoteResolvedAPI on thecdctest.Validatorrequires that the passedresolved timestamp is the resolved timetsamp / frontier for the whole set
of spans being tracked by the validator. Previously, tests would submit resolved
timestamps for subsets of spans at a time, which is incorrect. This would
not cause tests to fail because the order validator does not
assert that resolved timetsamps monotonically increase (tracked by #108872).
This change updates these tests to submit resolved timestamps for the
overall set of spans being tracked. After this change, fixing the
ordering validator in (#108872) will not cause these tests to fail.
Release note: None
Epic: None
changefeedccl: assert increasing resolved message timestamps in validators #108861
Previously, no validator in the
cdctestpackage would assert that resolved messages increase monotonically. This is an important ordering guarantee that changefeeds provide.This change updates the
orderValidatorto assert this.Release note: None
Epic: None
Fixes: #108872