ccl/sqlproxyccl: deflake TestConnectionMigration#108192
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 5, 2023
Merged
ccl/sqlproxyccl: deflake TestConnectionMigration#108192craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Fixes cockroachdb#106885. This test flake seems extremely rare, and it's unclear why it occurred in the first place. The past 1000 runs (all of what TC has) have been successful. Regardless, this commit attempts at deflaking TestConnectionMigration. Given that some subtests transfer connections through `transferConnWithRetries`, it is possible that the transfer was retried, causing the metric to be incremented. Release note: None Epic: none
26f8587 to
ee9ea9a
Compare
Contributor
Author
|
TFTR! All the test failures are unrelated. bors r=darinpp |
craig bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
108115: roachtest: don't reuse clusters that call dmsetup r=erikgrinaker,srosenberg a=andrewbaptist Certain tests need to modify the blockdevice and they are prone to failures during setup that the device is still busy. Ideally we would figure out what is still holding onto the dish handle, but it is safer to simply not reuse clusters that perform this by adding `spec.ReuseNone()` Fixes: #107865 Epic: none Release note: None 108165: sql: fix insight integration test for contention r=koorosh a=koorosh This change lowers the latency threshold for which statement is considered slow to make sure it detects contention. Previous value was set to 100ms which is default. New value is set to 30ms to be the same as overridden value in other tests. Release note: None Resolves: #108020 108192: ccl/sqlproxyccl: deflake TestConnectionMigration r=darinpp a=jaylim-crl Fixes #106885. This test flake seems extremely rare, and it's unclear why it occurred in the first place. The past 1000 runs (all of what TC has) have been successful. Regardless, this commit attempts at deflaking TestConnectionMigration. Given that some subtests transfer connections through `transferConnWithRetries`, it is possible that the transfer was retried, causing the metric to be incremented. Release note: None Epic: none Co-authored-by: Andrew Baptist <baptist@cockroachlabs.com> Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com> Co-authored-by: Jay <jay@cockroachlabs.com>
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106885.
This test flake seems extremely rare, and it's unclear why it occurred in the
first place. The past 1000 runs (all of what TC has) have been successful.
Regardless, this commit attempts at deflaking TestConnectionMigration. Given
that some subtests transfer connections through
transferConnWithRetries, itis possible that the transfer was retried, causing the metric to be
incremented.
Release note: None
Epic: none