Skip to content

ccl/multiregionccl: skip TestMultiRegionDataDriven#108107

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
kvoli:230803.skip-test-multi-region-datadriven
Aug 3, 2023
Merged

ccl/multiregionccl: skip TestMultiRegionDataDriven#108107
craig[bot] merged 1 commit intocockroachdb:masterfrom
kvoli:230803.skip-test-multi-region-datadriven

Conversation

@kvoli
Copy link
Copy Markdown
Contributor

@kvoli kvoli commented Aug 3, 2023

Failing consistently on nightly stress, skip.

Informs: #98020

Epic: none

Release note: None

Failing consistently on nightly stress, skip.

Informs: cockroachdb#98020

Epic: none

Release note: None
@kvoli kvoli self-assigned this Aug 3, 2023
@kvoli kvoli requested a review from a team as a code owner August 3, 2023 13:34
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @kvoli)

@kvoli
Copy link
Copy Markdown
Contributor Author

kvoli commented Aug 3, 2023

bors r=maryliag,chengxiong-ruan

@kvoli
Copy link
Copy Markdown
Contributor Author

kvoli commented Aug 3, 2023

TYFTRs

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 3, 2023

Build succeeded:

@craig craig bot merged commit 03b1d4c into cockroachdb:master Aug 3, 2023
kvoli added a commit to kvoli/cockroach that referenced this pull request Sep 6, 2023
`TestMultiRegionDataDriven` was skipped in cockroachdb#108107 due to finish
(tracing span) being called twice in raft reproposals cockroachdb#107521, which
 cockroachdb#108775 fixed.

Unskip the top level `TestMultiRegionDataDriven` test. Note
`/secondary_region` is still skipped due to a known allocator bug.

Informs: cockroachdb#98020
Epic: none
Release note: None
craig bot pushed a commit that referenced this pull request Sep 6, 2023
110063: ccl/multiregionccl: unskip test multi region dd parent test r=rafiss a=kvoli

`TestMultiRegionDataDriven` was skipped in #108107 due to finish
(tracing span) being called twice in raft reproposals #107521, which
 #108775 fixed.

Unskip the top level `TestMultiRegionDataDriven` test. Note
`/secondary_region` is still skipped due to a known allocator bug.

Informs: #98020
Epic: none
Release note: None

Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants