Skip to content

build: upgrade go to 1.19.10#104893

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rail:go-1.19.10
Jun 14, 2023
Merged

build: upgrade go to 1.19.10#104893
craig[bot] merged 1 commit intocockroachdb:masterfrom
rail:go-1.19.10

Conversation

@rail
Copy link
Copy Markdown
Member

@rail rail commented Jun 14, 2023 •
edited
Loading

  • Adjust the Pebble tests to run in new version.
  • Adjust version in Docker image (source).
  • Adjust version in the TeamCity agent image (setup script)
  • Rebuild and push the Docker image (following Basic Process)
  • Update build/teamcity/internal/release/build-and-publish-patched-go/impl.sh with the new version and adjust SHA256 sums as necessary.
  • Adjust GO_VERSION and GO_FIPS_COMMIT for the FIPS Go toolchain (source).
  • Run the Internal / Cockroach / Build / Toolchains / Publish Patched Go for Mac build configuration in TeamCity with your latest version of the script above. Note the job depends on another job Build and Publish Patched Go. That job prints out the SHA256 of all tarballs, which you will need to copy-paste into WORKSPACE (see below). Publish Patched Go for Mac is an extra step that publishes the signed go binaries for macOS. That job also prints out the SHA256 of the Mac tarballs in particular.
  • Adjust --@io_bazel_rules_go//go/toolchain:sdk_version in .bazelrc.
  • Bump the version in WORKSPACE under go_download_sdk. You may need to bump rules_go. Also edit the filenames listed in sdks and update all the hashes to match what you built in the step above.
  • Bump the version in WORKSPACE under go_download_sdk for the FIPS version of Go (go_sdk_fips).
  • Run ./dev generate bazel to refresh distdir_files.bzl, then bazel fetch @distdir//:archives to ensure you've updated all hashes to the correct value.
  • Bump the version in builder.sh accordingly (source).
  • Bump the version in go-version-check.sh (source), unless bumping to a new patch release.
  • Bump the go version in go.mod.
  • Bump the default installed version of Go in bootstrap-debian.sh (source).
  • Replace other mentions of the older version of go (grep for golang:<old_version> and go<old_version>).
  • Update the builder.dockerImage parameter in the TeamCity Cockroach and Internal projects.
  • Ask the Developer Infrastructure team to deploy new TeamCity agent images according to packer/README.md

Epic: none
Release note: None

@rail rail added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf labels Jun 14, 2023
@rail rail requested a review from a team as a code owner June 14, 2023 16:20
@rail rail self-assigned this Jun 14, 2023
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jun 14, 2023

This change is Reviewable

@rail rail mentioned this pull request Jun 14, 2023
Closed
@rail rail requested a review from a team as a code owner June 14, 2023 17:34
@rail rail requested review from smg260 and srosenberg and removed request for a team June 14, 2023 17:34
@rail rail added the backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only label Jun 14, 2023
@rail
build: upgrade go to 1.19.10
a6e8fbd 
* [ ] Adjust the Pebble tests to run in new version.
* [ ] Adjust version in Docker image ([source](./builder/Dockerfile)).
* [ ] Adjust version in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh))
* [ ] Rebuild and push the Docker image (following [Basic Process](#basic-process))
* [ ] Update `build/teamcity/internal/release/build-and-publish-patched-go/impl.sh` with the new version and adjust SHA256 sums as necessary.
* [ ] Adjust `GO_VERSION` and `GO_FIPS_COMMIT` for the FIPS Go toolchain ([source](./teamcity/internal/release/build-and-publish-patched-go/impl-fips.sh)).
* [ ] Run the `Internal / Cockroach / Build / Toolchains / Publish Patched Go for Mac` build configuration in TeamCity with your latest version of the script above. Note the job depends on another job `Build and Publish Patched Go`. That job prints out the SHA256 of all tarballs, which you will need to copy-paste into `WORKSPACE` (see below). `Publish Patched Go for Mac` is an extra step that publishes the *signed* `go` binaries for macOS. That job also prints out the SHA256 of the Mac tarballs in particular.
* [ ] Adjust `--@io_bazel_rules_go//go/toolchain:sdk_version` in [.bazelrc](../.bazelrc).
* [ ] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit the filenames listed in `sdks` and update all the hashes to match what you built in the step above.
* [ ] Bump the version in `WORKSPACE` under `go_download_sdk` for the FIPS version of Go (`go_sdk_fips`).
* [ ] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then `bazel fetch @distdir//:archives` to ensure you've updated all hashes to the correct value.
* [ ] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)).
* [ ] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release.
* [ ] Bump the go version in `go.mod`.
* [ ] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)).
* [ ] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`).
* [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects.
* [ ] Ask the Developer Infrastructure team to deploy new TeamCity agent images according to [packer/README.md](./packer/README.md)

Epic: none
Release note: None
srosenberg
srosenberg approved these changes Jun 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@srosenberg srosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@rail
Copy link
Copy Markdown
Member Author

rail commented Jun 14, 2023

bors r=srosenberg

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 14, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 14, 2023

Build succeeded:

@craig craig bot merged commit 5741b95 into cockroachdb:master Jun 14, 2023
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jun 14, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating merge commit from a6e8fbd to blathers/backport-release-23.1-104893: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rail rail mentioned this pull request Jun 14, 2023
Merged
18 tasks
@rail rail deleted the go-1.19.10 branch June 14, 2023 20:17
michae2 added a commit to michae2/cockroach that referenced this pull request Jun 15, 2023
@michae2
build: fix checksum for go1.19.10.darwin-amd64.tar.gz
01a14b8 
For some reason the checksum for `go1.19.10.darwin-amd64.tar.gz` from
cockroachdb#104893 didn't match for
me. This one worked. I'm not sure why.

Epic: None
Release note: None
@michae2 michae2 mentioned this pull request Jun 15, 2023
Merged
craig bot pushed a commit that referenced this pull request Jun 15, 2023
@michae2
Merge #104936
ef1ce99 
104936: build: fix checksum for go1.19.10.darwin-amd64.tar.gz r=rail a=michae2

For some reason the checksum for `go1.19.10.darwin-amd64.tar.gz` from #104893 didn't match for me. This one worked. I'm not sure why.

Epic: None
Release note: None

Co-authored-by: Michael Erickson <michae2@cockroachlabs.com>
rail pushed a commit to rail/cockroach that referenced this pull request Jun 15, 2023
@michae2 @rail
build: fix checksum for go1.19.10.darwin-amd64.tar.gz
a7212d0 
For some reason the checksum for `go1.19.10.darwin-amd64.tar.gz` from
cockroachdb#104893 didn't match for
me. This one worked. I'm not sure why.

Epic: None
Release note: None
@rail rail mentioned this pull request Jun 20, 2023
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srosenberg srosenberg srosenberg approved these changes

@smg260 smg260 Awaiting requested review from smg260 smg260 was automatically assigned from cockroachdb/test-eng

Assignees

@rail rail

Labels

A-build-system backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rail @cockroach-teamcity @srosenberg