kv: remove stale TODO about commit triggers#103863
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 25, 2023
Merged
kv: remove stale TODO about commit triggers#103863craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Closes cockroachdb#18170. As of c00ea84, `Txn.PrepareForRetry` is called for all transaction retries, regardless of whether they're automatically performed by `Txn.exec` or manually performed by the client. As a result, the TODO describing the need to reset commit triggers separately for user-directed retry attempts is no longer relevant. Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
miraradeva
approved these changes
May 24, 2023
Contributor
miraradeva
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
miraradeva
approved these changes
May 24, 2023
Contributor
miraradeva
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
Contributor
Author
|
TFTR! bors r=miraradeva |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18170.
As of c00ea84,
Txn.PrepareForRetryis called for all transaction retries, regardless of whether they're automatically performed byTxn.execor manually performed by the client. As a result, the TODO describing the need to reset commit triggers separately for user-directed retry attempts is no longer relevant.Release note: None