-
Notifications
You must be signed in to change notification settings - Fork 4.1k
client: txn commit triggers are reset in the wrong place #18170
Copy link
Copy link
Open
Labels
A-kv-clientRelating to the KV client and the KV interface.Relating to the KV client and the KV interface.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-kvKV TeamKV Team
Milestone
Description
A Txn has a commitTriggers field:
// commitTriggers are run upon successful commit.
commitTriggers []func()
They are always reset before an auto-retry. However, they are not reset before a user-directed retry. So I believe a trigger can be executed multiple times. We should figure out another strategy for clearing them.
cockroach/pkg/internal/client/txn.go
Line 769 in ef021b3
| txn.commitTriggers = nil |
cc @spencerkimball @nvanbenschoten
Jira issue: CRDB-6016
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-kv-clientRelating to the KV client and the KV interface.Relating to the KV client and the KV interface.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-kvKV TeamKV Team