sql: fix the index/table span generation in SHOW RANGES#103667
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 23, 2023
Merged
sql: fix the index/table span generation in SHOW RANGES#103667craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Prior to this patch, the `table_`/`index_` start/end key pairs emitted under WITH TABLES/INDEXES were incorrectly computed to span the entire SQL object, not just the intersection between the object and the current range. This patch fixes it. Release note (bug fix): When the option `WITH TABLES` or `WITH INDEXES` is passed to `SHOW RANGES`, the per-object start/end key columns now properly refer to the part of the object included inside the range identified by the current row. Previously, they could incorrectly point to keys outside of the current range's boundaries. This bug had been introduced in v23.1.
Member
|
This change is |
Contributor
Author
|
TFYR! bors r=zachlite |
Contributor
|
Build failed: |
Contributor
Author
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103665.
Needed for #103128.
Epic: CRDB-24928.
Prior to this patch, the
table_/index_start/end key pairs emitted under WITH TABLES/INDEXES were incorrectly computed to span the entire SQL object, not just the intersection between the object and the current range.This patch fixes it.
Release note (bug fix): When the option
WITH TABLESorWITH INDEXESis passed toSHOW RANGES, the per-object start/end key columns now properly refer to the part of the object included inside the range identified by the current row. Previously, they could incorrectly point to keys outside of the current range's boundaries. This bug had been introduced in v23.1.