Skip to content

upgrademanager: audit tests that use MakeTestingClusterSettingsWithVersions#100873

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-upgrademanager-tests
Apr 7, 2023
Merged

upgrademanager: audit tests that use MakeTestingClusterSettingsWithVersions#100873
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-upgrademanager-tests

Conversation

@rafiss
Copy link
Copy Markdown
Collaborator

@rafiss rafiss commented Apr 6, 2023

informs #100552

Release note: None

@rafiss rafiss added the backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only label Apr 6, 2023
@rafiss rafiss requested review from a team, adityamaru and knz April 6, 2023 20:45
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Apr 6, 2023

bors r+

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Apr 6, 2023

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 6, 2023

Already running a review

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 7, 2023

Build failed:

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Apr 7, 2023

flake fixed by #100895

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 7, 2023

Build succeeded:

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 7, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-100873 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/100899/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@nvb
Copy link
Copy Markdown
Contributor

nvb commented Apr 7, 2023

In #100900, we saw TestConcurrentMigrationAttempts (touched here) hit a timeout. There's no history of this test failing, so some flakiness may have been uncovered by these changes.

@rafiss rafiss deleted the fix-upgrademanager-tests branch April 7, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants