upgrades: fix race condition in TestWaitForDelRangeInGCJob#100895
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 7, 2023
Merged
upgrades: fix race condition in TestWaitForDelRangeInGCJob#100895craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously, this test relied on a migration to guarantee, a schema change GC job would complete before we checked the index/table keys (to validate clean up of data). This migration incorrectly waited for the GC job to fully complete, even if the job didn't start allowing this test to pass. After fixing this issue, this test suffers from a race condition since the job may not complete before the version finalizes now. To address this, this patch adds a SucceedsSoon, since the job should wake up and clean up shortly with DelRange enabled. Fixes: cockroachdb#100853 Release note: None
Member
|
This change is |
rafiss
approved these changes
Apr 7, 2023
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
awesome, thanks for the quick fix!
Collaborator
Author
|
@rafiss TFTR! bors r+ |
Contributor
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-23.1-100895 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/100897/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this test relied on a migration to guarantee, a schema change GC job would complete before we checked the index/table keys (to validate clean up of data). This migration incorrectly waited for the GC job to fully complete, even if the job didn't start allowing this test to pass. After fixing this issue, this test suffers from a race condition since the job may not complete before the version finalizes now. To address this, this patch adds a SucceedsSoon, since the job should wake up and clean up shortly with DelRange enabled.
Fixes: #100853
Release note: None