-
Notifications
You must be signed in to change notification settings - Fork 4.1k
sql schema: remove/fix tests that were ignored from bumping minBinary to V22_2 #96751
Copy link
Copy link
Closed
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)GA-blockerT-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)branch-release-23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1
Description
In order to bump minBinary to V22_2, we ignored failing tests for future async removal/fixing
- issue: clusterversion: bump binaryMinSupportedVersion to 22.2 #95530
- pr: clusterversion: bump minBinary to 22.2 #96656
This issue is to track removing/fixing tests as needed for SQL Schema:
pkg/sql
- TestGatingCreateFunction (SQL Schema)
pkg/upgrade/upgrades: (SQL Schema)
TestAlterSystemSqlInstancesTable- TestAlterSystemStatementStatisticsTable
TestIsAtLeastVersionBuiltin-- looks like just delete the test, but let's ask @yuzefovich- Yahor: yeah, just delete this test
- TestSampledStmtDiagReqsMigration -- this is related to kv: remove V22_2 gates and related logic/migrations/etc #96765; not our work
- TestSchemaTelemetrySchedule -- unskip after upgrades: make the schema telemetry job setup permanent #98690
- TestWaitForSchemaChangeMigration -- looks like can delete the test, but let's ask @stevendanna
- TestWaitForSchemaChangeMigrationSynthetic -- looks like can delete the test, but let's ask @stevendanna
Jira issue: CRDB-24309
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)GA-blockerT-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)branch-release-23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1