Skip to content

upgrades: make the schema telemetry job setup permanent#98690

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/make-schema-telemetry-job-permanent
Apr 3, 2023
Merged

upgrades: make the schema telemetry job setup permanent#98690
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/make-schema-telemetry-job-permanent

Conversation

@ajwerner
Copy link
Copy Markdown
Contributor

This migration should run for every cluster.

Epic: none

Informs: #96763

Release note: None

@ajwerner ajwerner requested a review from a team March 15, 2023 17:16
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@ajwerner ajwerner added the backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only label Mar 27, 2023
@ajwerner ajwerner force-pushed the ajwerner/make-schema-telemetry-job-permanent branch from df1297e to e8ee242 Compare March 27, 2023 17:20
@ajwerner ajwerner requested a review from a team as a code owner March 27, 2023 17:20
Copy link
Copy Markdown
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajwerner ajwerner force-pushed the ajwerner/make-schema-telemetry-job-permanent branch from e8ee242 to 6af98fc Compare March 27, 2023 18:52
@ajwerner
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 28, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 28, 2023

Build failed:

@rafiss
Copy link
Copy Markdown
Collaborator

rafiss commented Mar 28, 2023

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 28, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 29, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 29, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 29, 2023

Build failed:

@ajwerner
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 31, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 31, 2023

Build failed (retrying...):

@ajwerner
Copy link
Copy Markdown
Contributor Author

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 31, 2023

Canceled.

@ajwerner ajwerner force-pushed the ajwerner/make-schema-telemetry-job-permanent branch from 6af98fc to e49e495 Compare March 31, 2023 04:28
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 31, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 31, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 31, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 1, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 1, 2023

Build failed:

@rafiss
Copy link
Copy Markdown
Collaborator

rafiss commented Apr 1, 2023

flakes were #98554 (comment) #100369 #100356

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 1, 2023

Build failed:

@rafiss
Copy link
Copy Markdown
Collaborator

rafiss commented Apr 3, 2023

bors r+

@ajwerner
Copy link
Copy Markdown
Contributor Author

ajwerner commented Apr 3, 2023

bors r-

I think this needs another rewrite

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 3, 2023

Canceled.

@ajwerner ajwerner force-pushed the ajwerner/make-schema-telemetry-job-permanent branch from e49e495 to cfbb661 Compare April 3, 2023 15:16
@ajwerner
Copy link
Copy Markdown
Contributor Author

ajwerner commented Apr 3, 2023

Updated, will bors assuming CI passes

This migration should run for every cluster.

Epic: none

Informs: cockroachdb#96763

Release note: None
@ajwerner ajwerner force-pushed the ajwerner/make-schema-telemetry-job-permanent branch from cfbb661 to 75c083c Compare April 3, 2023 15:30
@ajwerner
Copy link
Copy Markdown
Contributor Author

ajwerner commented Apr 3, 2023

bors r+

@craig craig bot merged commit 6cd1f1b into cockroachdb:master Apr 3, 2023
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 3, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants