-
Notifications
You must be signed in to change notification settings - Fork 4.1k
ui: Allow text entry in the time selector #80655
Copy link
Copy link
Closed
Labels
A-sql-console-generalSQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud ConsoleSQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud ConsoleC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Metadata
Metadata
Assignees
Labels
A-sql-console-generalSQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud ConsoleSQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud ConsoleC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Breaking this off from #78499 and #71205 into a separate issue, to document some findings. See video at 0:57 https://www.loom.com/share/d17dc4cac1c146029b1600f30e59e79f.
The component is from the antd library, specifically this component https://ant.design/components/time-picker/

The
(UTC)seems to come from theformatprop, specified in our code here.This prop is not well documented in terms of what formats that it accepts. There is some documentation on formats here, but they do not describe things likeTheAor[]which we use in our code. I tried to dig a bit into the source code but didn't get very far.formatstring follows themomentlibrary's display format string.The current time picker behavior is such that text entry requires either
(UTC)In both cases, you know you've "succeeded" because the component does a smooth scroll to the time you have typed.
Changing
formatwiths/"h:mm A [(UTC)]"/"h:mm A[ (UTC)]"does not fix the issue.Jira issue: CRDB-15565