The contents of the --locality-advertise-addr flag never actually get plumbed into the server/gossip code, meaning that the feature almost certainly doesn't work.
The localityAddress arg to Node.start is unused:
|
localityAddress []roachpb.LocalityAddress, |
The NodeDescriptor.LocalityAddress field never actually gets set anywhere in our code:
https://sourcegraph.com/github.com/cockroachdb/cockroach@master/-/blob/pkg/roachpb/metadata.pb.go#L166:2=&tab=references
That should be fixed and the feature tested end-to-end.
The contents of the
--locality-advertise-addrflag never actually get plumbed into the server/gossip code, meaning that the feature almost certainly doesn't work.The
localityAddressarg toNode.startis unused:cockroach/pkg/server/node.go
Line 396 in 44a5f06
The
NodeDescriptor.LocalityAddressfield never actually gets set anywhere in our code:https://sourcegraph.com/github.com/cockroachdb/cockroach@master/-/blob/pkg/roachpb/metadata.pb.go#L166:2=&tab=references
That should be fixed and the feature tested end-to-end.