Skip to content

util/log: use runtime.CallersFrames instead of runtime.Callers #17770

@tbg

Description

@tbg

http://talks.godoc.org/github.com/davecheney/go-1.9-release-party/presentation.slide#20

[tschottdorf@macts-2 cockroach (node-info)]$ git grep runtime.Caller
pkg/storage/timedmutex.go:                      if pc, _, _, ok := runtime.Caller(2); ok {
pkg/storage/track_raft_protos.go:               if numCallers := runtime.Callers(0, pcs[:]); numCallers == len(pcs) {
pkg/storage/track_raft_protos.go:               frames := runtime.CallersFrames(pcs[:])
pkg/util/caller/resolver.go:// A CallResolver is a helping hand around runtime.Caller() to look up file,
pkg/util/caller/resolver.go:// it's unable to look up its own location via runtime.Caller().
pkg/util/caller/resolver.go:    _, file, _, ok := runtime.Caller(0)
pkg/util/caller/resolver.go:    pc, file, line, ok := runtime.Caller(depth + 1)
pkg/util/caller/resolver.go:                    // "path/filepath" because runtime.Caller always returns unix paths.
pkg/util/caller/resolver_test.go:               // NB: runtime.Caller always returns unix paths.
pkg/util/envutil/env.go:        _, consumer, _, _ := runtime.Caller(depth + 1)
pkg/util/log/clog.go:           if runtime.Callers(2+depth, logging.pcs[:]) == 0 {
pkg/util/log/test_log_scope.go: runtime.Callers(2, pcs[:])
pkg/util/log/test_log_scope.go: frames := runtime.CallersFrames(pcs[:])
pkg/util/smalltrace.go: nCallers := runtime.Callers(skip, pcs[:])
pkg/util/smalltrace.go: frames := runtime.CallersFrames(pcs[:])

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-performancePerf of queries or internals. Solution not expected to change functional behavior.E-easyEasy issue to tackle, requires little or no CockroachDB experiencehelp wantedHelp is requested / needed by the one who filed the issue to fix it.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions