Skip to content

roachtest: fail when github issuePoster returns an error #147116

@srosenberg

Description

@srosenberg

Currently, roachtest logs the error from github.MaybePost [1], but doesn't actually fail the run. In CI, this is a problem because a test failure may go unreported. Based on my preliminary check, of test.log of several dozen recent failures, there are no occurrences; i.e., it's rare, but we know that GH outages do happen from time to time.

In [2], we added logging to print the issue that was created or appended. Yet, we're missing an active alerting mechanism to detect "silent" issuePoster failures. Failing the run would also fail the CI job which is actively monitored by testeng.

[1]

if _, err := github.MaybePost(t, l, t.failureMsg(), params); err != nil {
shout(ctx, l, stdout, "failed to post issue: %s", err)

[2] #118914

Jira issue: CRDB-50886

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)E-quick-winLikely to be a quick win for someone experienced.E-starterMight be suitable for a starter project for new employees or team members.T-testengTestEng Teamv25.4.0-prerelease

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions