-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Assess and fix potential unsafe locks #107946
Copy link
Copy link
Closed
Labels
A-observability-infC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.db-cy-23
Description
Describe the problem
Relates to discussion on #105366. The external linter produced a txt file listing potentially unsafe locks. This issue tracks the work to assess and fix any unsafe locks. Any existing unlocks that aren't deferred but are deemed safe should add the nolint:deferunlock comment which will be introduced in #107577 since the linter will catch any of those usages and error on build.
#107665 fixed usages in the sql package but there are still many other places that need to be assessed.
Jira issue: CRDB-30267
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-observability-infC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.db-cy-23