sql: clean up some uses of Unlock#107665
Conversation
|
This change is |
maryliag
left a comment
There was a problem hiding this comment.
Thank you fixing this! Would you mind also updating here (since is also under sql package)?
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @Santamaura, @smg260, @srosenberg, and @yuzefovich)
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:
pkg/sql/sqlliveness/slstorage/slstorage.go line 232 at r1 (raw file):
// At this point, we know that the singleflight goroutine has been launched. // Releasing the lock here ensures that callers will either join the single-
nit: this comment might need an update given that we no longer release the lock right below.
RaduBerinde
left a comment
There was a problem hiding this comment.
Done
Reviewable status:
maryliag
left a comment
There was a problem hiding this comment.
I will leave for other teams to check their code, but for the ones under sql/sqlstats
Reviewed 6 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
dhartunian
left a comment
There was a problem hiding this comment.
tracer.go and histogram.go 
Reviewed 2 of 7 files at r1.
Reviewable status:
RaduBerinde
left a comment
There was a problem hiding this comment.
TFTRs!
Essential CI failure is a flake that already has an issue filed.
bors r+
Reviewable status:
|
Build failed (retrying...): |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build failed (retrying...): |
|
Build failed: |
This is a minor cleanup change to use `defer.Unlock` when there are multiple exit paths that need to unlock. Epic: none Release note: None
|
bors r+ |
|
Timed out. |
|
bors r+ |
|
Build succeeded: |
This is a minor cleanup change to use
defer.Unlockwhen there are multiple exit paths that need to unlock.Epic: none
Release note: None