Skip to content

apd: add Size method#97

Closed
yuzefovich wants to merge 1 commit intomasterfrom
size
Closed

apd: add Size method#97
yuzefovich wants to merge 1 commit intomasterfrom
size

Conversation

@yuzefovich
Copy link
Copy Markdown
Member

No description provided.

@yuzefovich yuzefovich requested a review from asubiotto October 8, 2020 20:48
@asubiotto
Copy link
Copy Markdown

It doesn't feel like this is something that apd should provide. We already have a SizeOfDecimal function in pkg/sql/sem/tree/datum.go, is that not what you need?

@yuzefovich
Copy link
Copy Markdown
Member Author

Oh, indeed, I don't why I didn't check that myself.

@yuzefovich yuzefovich closed this Oct 12, 2020
@yuzefovich yuzefovich deleted the size branch October 12, 2020 16:04
nvb added a commit to nvb/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvb added a commit to nvb/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvb added a commit to nvb/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvb added a commit to nvb/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvb added a commit to nvb/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvb added a commit to nvb/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
nvb added a commit to nvb/apd that referenced this pull request Jan 6, 2022
Revives cockroachdb#97.

I disagree with the rationale behind closing that PR. This logic belongs
in this package more than it belongs in CockroachDB code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants