Skip to content

upgrade kind from 0.23.0 to 0.25.0#481

Merged
nabuskey merged 3 commits intocnoe-io:mainfrom
squidboylan:kind-upgrade
Jan 28, 2025
Merged

upgrade kind from 0.23.0 to 0.25.0#481
nabuskey merged 3 commits intocnoe-io:mainfrom
squidboylan:kind-upgrade

Conversation

@squidboylan
Copy link
Copy Markdown
Contributor

@squidboylan squidboylan commented Jan 26, 2025 •
edited
Loading

0.25.0 contains a fix for running kind in codespaces without introducing many breaking changes.

The only breaking changes between 0.23.0 and 0.25.0 are changes to the default k8s node image (1.30.0 -> 1.31.2). We could upgrade to 0.26.0 but it's not necessary for the fix mentioned in #420 .

Fixes #420

@squidboylan
upgrade kind from 0.23.0 to 0.25.0
c2ea199 
0.25.0 contains a fix for running kind in codespaces without introducing
many breaking changes

Signed-off-by: Caleb Boylan <calebboylan@gmail.com>
@squidboylan squidboylan requested a review from a team as a code owner January 26, 2025 23:37
@squidboylan
Copy link
Copy Markdown
Contributor Author

squidboylan commented Jan 26, 2025

I see that we override the default k8s node image and set it to 1.30.3. Do we want to update that as part of the kind upgrade to be inline with what kind defaults to? We could upgrade to the latest 1.31 patch (1.31.5).

@nabuskey
Copy link
Copy Markdown
Collaborator

nabuskey commented Jan 28, 2025 •
edited
Loading

Yeah we should keep our default value with the kind version we use. We also need to test Codespace works because we had to create a workaround for it specifically due to kind version we were using. #419

Thank you for this PR!

@squidboylan
remove codespaces workaround
35d52f7 
Signed-off-by: Caleb Boylan <calebboylan@gmail.com>
@squidboylan
upgrade default k8s node version to 1.31.4
c1634d1 
Signed-off-by: Caleb Boylan <calebboylan@gmail.com>
@squidboylan
Copy link
Copy Markdown
Contributor Author

squidboylan commented Jan 28, 2025 

@squidboylan ➜ ~/idpbuilder (kind-upgrade) $ k get nodes
NAME                     STATUS   ROLES           AGE   VERSION
localdev-control-plane   Ready    control-plane   98s   v1.31.4
@squidboylan ➜ ~/idpbuilder (kind-upgrade) $ docker ps
CONTAINER ID   IMAGE                  COMMAND                  CREATED              STATUS              PORTS                                              NAMES
1ad3eacf11fe   kindest/node:v1.31.4   "/usr/local/bin/entr…"   About a minute ago   Up About a minute   0.0.0.0:8443->443/tcp, 127.0.0.1:42071->6443/tcp   localdev-control-plane
@squidboylan ➜ ~/idpbuilder (kind-upgrade) $ k get pods -A
NAMESPACE            NAME                                                READY   STATUS      RESTARTS   AGE
argocd               argocd-application-controller-0                     1/1     Running     0          50s
argocd               argocd-applicationset-controller-6c6d75b86f-xrdgb   1/1     Running     0          51s
argocd               argocd-redis-6668955c45-pcp8q                       1/1     Running     0          51s
argocd               argocd-repo-server-7fd9bd6445-gqzbw                 1/1     Running     0          50s
argocd               argocd-server-7cb7cd5b7-df6hg                       1/1     Running     0          50s
gitea                my-gitea-64c8b6945f-qwghz                           1/1     Running     0          94s
ingress-nginx        ingress-nginx-admission-create-6phc2                0/1     Completed   0          94s
ingress-nginx        ingress-nginx-admission-patch-vc6hr                 0/1     Completed   0          94s
ingress-nginx        ingress-nginx-controller-795dfd6796-kxkzr           1/1     Running     0          94s
kube-system          coredns-6bc7f4b99d-dm5m7                            1/1     Running     0          94s
kube-system          coredns-6bc7f4b99d-sx4jk                            1/1     Running     0          94s
kube-system          etcd-localdev-control-plane                         1/1     Running     0          101s
kube-system          kindnet-8bhsc                                       1/1     Running     0          94s
kube-system          kube-apiserver-localdev-control-plane               1/1     Running     0          101s
kube-system          kube-controller-manager-localdev-control-plane      1/1     Running     0          101s
kube-system          kube-proxy-crz7h                                    1/1     Running     0          94s
kube-system          kube-scheduler-localdev-control-plane               1/1     Running     0          101s
local-path-storage   local-path-provisioner-6fdc965494-zp29c             1/1     Running     0          94s
@squidboylan ➜ ~/idpbuilder (kind-upgrade) $ git rev-parse --short HEAD
c1634d1

codespaces seems to work for me with the latest commit that upgrades the default node to 1.31.4 . @nabuskey is this a sufficient test? Based on the workaround I assume it didnt get this far before.

nabuskey
nabuskey approved these changes Jan 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you very much!

@nabuskey nabuskey merged commit 3c6ed6f into cnoe-io:main Jan 28, 2025
cmoulliard pushed a commit to ch007m/fork-idpbuilder that referenced this pull request Mar 13, 2025
@squidboylan @cmoulliard
upgrade kind from 0.23.0 to 0.25.0 (cnoe-io#481)
1b85748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nabuskey nabuskey nabuskey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update kind

2 participants

@squidboylan @nabuskey