add support for http and https kind-configs#480
Merged
nabuskey merged 1 commit intocnoe-io:mainfrom Jan 28, 2025
Merged
Conversation
cmoulliard
approved these changes
Jan 27, 2025
nabuskey
requested changes
Jan 27, 2025
Signed-off-by: Caleb Boylan <calebboylan@gmail.com>
1cf35f0 to
e17aae5
Compare
nabuskey
approved these changes
Jan 28, 2025
Collaborator
nabuskey
left a comment
There was a problem hiding this comment.
LGTM. Thank you!
This file is getting a bit too much. We need to refactor it to support easier unit testing. I'll open an issue.
Contributor
Author
Yeah I was thinking the same, I'll take a stab at that shortly. |
Merged
cmoulliard
pushed a commit
to ch007m/fork-idpbuilder
that referenced
this pull request
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #454