Expose the gitea ssh port on 32222#478
Conversation
1690c68 to
7b2cbde
Compare
|
I created my cluster with: and below is what the UI shows |
|
I am ok with this but @cmoulliard did raise a good point in the thread on this issue about the port not matching what the references to the git repos are. I think as long as we continue to use the https urls for pulls and we just use the ssh for special purpose or edge cases then this is fine. I don't want to see a mix of references to both though. I think when we are building automation in idpbuilder or related stacks we should stick to the https. @nabuskey what do you think? |
|
Looks good to me. I think https clone / push is an easier way because you can get the token and the password (could be static password) with a idpbuilder command. We should support SSH too because there's no draw back as far as I can tell. |
13ebfe7 to
d0896cc
Compare
Sets up gitea ssh to be exposed at 32222 on the host network, docker container, and cluster service layers. Signed-off-by: Caleb Boylan <calebboylan@gmail.com>
d0896cc to
3fdb3a1
Compare
|
/e2e |
Signed-off-by: Caleb Boylan <calebboylan@gmail.com>
Sets up gitea ssh to be exposed at 32222 on the host network, container, and service layers.
It's unclear to me if we always want to expose this port. If we decide the host port we can ensure the gitea
SSH_PORTsetting matches which makes the ssh clone URL in gitea work.fixes #227