Skip to content

add git client timeouts#206

Merged
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:fix/git-timeout
Apr 23, 2024
Merged

add git client timeouts#206
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:fix/git-timeout

Conversation

@nabuskey
Copy link
Copy Markdown
Collaborator

Fixes an issue where TCP connection to the gitea server times out and the reconciler could not finish its job.

  • Adds go-git client timeout values for TCP and HTTP.
  • Clone repositories with context instead.

Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
Copy link
Copy Markdown
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix

@nimakaviani nimakaviani merged commit f60a780 into cnoe-io:main Apr 23, 2024
@nabuskey nabuskey deleted the fix/git-timeout branch April 24, 2024 00:01
nimakaviani added a commit that referenced this pull request May 16, 2024
we fixed it for the gitCliet in #206 but same can occur
with the gitea client and this PR fixes it

Signed-off-by: Nima Kaviani <nkaviani@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants