Fix #437, #438 and #440 by manoelcampos · Pull Request #439 · cloudsimplus/cloudsimplus

manoelcampos · 2023-05-10T21:45:15Z

- Remove useless (unused) attributes vmm, architecture and os - Update docs Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

to indicate the distribution type of a Datacenter as public or private (default value). Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

since the implementations of multiple policies in CloudSim Plus are very different and have a higher performance than CloudSim's ones. Update authorship. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

on VmAllocationPolicyMigrationAbstract Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

to HostAbstract Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

and because it wasn't being used. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

to avoid multiple places where a VM destruction request can be performed, since those different methods were executing different logics. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

to HostAbstract. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

since the former doesn't have any attributes. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

- Computes VM live migration time based on the VM RAM utilization (allocated capacity) not the total capacity. - Update VM live migration message Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

implemeting on HostAbstract and VmAbstract. Moves the VM destruction request from DatacenterBrokerAbstract.requestIdleVmDestruction() to the new VmAbstract.shutdown() method. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

The Cloudlet.lifeTime empty value is Double.MAX_VALUE, not -1 anymore. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

codacy-production · 2023-05-11T09:36:25Z

Coverage summary from Codacy

Merging #439 (8c89541) into master (877776c) - See PR on Codacy

Coverage variation	Diff coverage
+0.08%	35.82%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`877776c`)	9278	3643	39.27%
Head commit (`8c89541`)	9285 (+7)	3653 (+10)	39.34% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#439)	134	48	35.82%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

…n enum to be used as a prefix to indicate if a datacenter is in a public or private cloud. Changes HostSimple.toString to show the Distribution symbol. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

by calling deallocateResourcesOfVm(). Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

those ones which are already created. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

just to assess a new VM placement. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

…rectly. - Calls vm.setCreated inside HostAbstract.createVmInternal. - Moves Vm.setCreated to VmAbstract since this method cannot be called directly Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

it's a non-live migration from/to a public-cloud datacenter. This way, it's forced to be shutdown and no "running cloudlets" warning must be shown. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

when printing logs, so that the toString() method is used instead. For datacenters, that will show the datacenter distribution (# for private, + for public-cloud datacenters) Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

manoelcampos added 13 commits May 10, 2023 16:07

DatacenterCharacteristics cleanup

3b59856

- Remove useless (unused) attributes vmm, architecture and os - Update docs Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Introduces DatacenterCharacteristics.Distribution enum

682acdf

to indicate the distribution type of a Datacenter as public or private (default value). Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Update VmAllocationPolicyMigrationAbstract docs

f2145d1

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Remove old mentions to CloudSim papers,

30c2ede

since the implementations of multiple policies in CloudSim Plus are very different and have a higher performance than CloudSim's ones. Update authorship. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Simplifies utilization o Lombok's Getter and Setter annotations

3e5289f

on VmAllocationPolicyMigrationAbstract Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

VmAllocationPolicyMigrationAbstract refactoring

93d3f64

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

DatacenterSimple refactoring

e144c20

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Move Host.destroyVm, destroyTemporaryVm and destroyAllVms

e9ed170

to HostAbstract Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Remove VM_DESTROY_ACK for simplification

d6498fd

and because it wasn't being used. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Removes DatacenterBroker.destroyVm

0e6a5be

to avoid multiple places where a VM destruction request can be performed, since those different methods were executing different logics. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Update DatacenterCharacteristics.Distribution docs

91f3911

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Update Host docs

a9cca84

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Define VmAbstract parameters final

edb9ee0

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

manoelcampos self-assigned this May 10, 2023

manoelcampos marked this pull request as draft May 10, 2023 21:46

manoelcampos added bug enhancement labels May 10, 2023

manoelcampos added 8 commits May 11, 2023 06:26

Fix #440 - Move Lombok EqualsAndHashCode annotation from HostSimple

ed3703b

to HostAbstract. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Move Lombok Accessors annotation from VmSimple to VmAbstract,

9bea5cd

since the former doesn't have any attributes. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Update CloudletSimple and HostSimple authorship

77c8670

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Fix #438

277f8ff

- Computes VM live migration time based on the VM RAM utilization (allocated capacity) not the total capacity. - Update VM live migration message Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Refactor Datacenter.timeToMigrateVm()

14fcc1c

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Add ExecDelayable.shutdown(),

8434cbe

implemeting on HostAbstract and VmAbstract. Moves the VM destruction request from DatacenterBrokerAbstract.requestIdleVmDestruction() to the new VmAbstract.shutdown() method. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

VmAllocationPolicyMigrationAbstract refactoring

1e7c2d2

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Fix DatacenterBrokerAbstract message for finished Cloudlet.

1eb77e5

The Cloudlet.lifeTime empty value is Double.MAX_VALUE, not -1 anymore. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

manoelcampos force-pushed the issue-437 branch from 7f82824 to 7ea7dd8 Compare May 11, 2023 09:32

manoelcampos force-pushed the issue-437 branch 3 times, most recently from 6fb8854 to 882b9b9 Compare May 11, 2023 15:13

manoelcampos force-pushed the issue-437 branch 4 times, most recently from c582fa2 to be38349 Compare May 11, 2023 15:42

manoelcampos changed the title ~~Fix #437 and #438~~ Fix #43, #438 and #440 May 11, 2023

manoelcampos changed the title ~~Fix #43, #438 and #440~~ Fix #437, #438 and #440 May 11, 2023

manoelcampos force-pushed the issue-437 branch 2 times, most recently from 6b7b31a to bdbc9f4 Compare May 11, 2023 20:30

manoelcampos added 12 commits May 11, 2023 17:36

Adds a symbol char attribute to DatacenterCharacteristics.Distributio…

6222e1d

…n enum to be used as a prefix to indicate if a datacenter is in a public or private cloud. Changes HostSimple.toString to show the Distribution symbol. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Code format

7de2e25

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Remove code duplication on HostAbstract.destroyAllVms(),

516f3e3

by calling deallocateResourcesOfVm(). Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Only selects as migratable VMs (Vms which are eligible for migration)

e5cc6d8

those ones which are already created. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Avoids showing VM creation logs when creating temporary VMs

4008974

just to assess a new VM placement. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

- Move Vm.setHost to VmAbstract since that method cannot be called di…

6a0d705

…rectly. - Calls vm.setCreated inside HostAbstract.createVmInternal. - Moves Vm.setCreated to VmAbstract since this method cannot be called directly Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Refactoring and docs update

be31c67

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Shows the Host where a VM is being shutdown

7dfaea1

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Close #437 - Implements non-live VM migration

0735507

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

If the VM is in migration and was destroyed,

cfcc99b

it's a non-live migration from/to a public-cloud datacenter. This way, it's forced to be shutdown and no "running cloudlets" warning must be shown. Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

Version bump to 8.4.0

8c89541

Signed-off-by: Manoel Campos <manoelcampos@gmail.com>

manoelcampos force-pushed the issue-437 branch from bdbc9f4 to 8c89541 Compare May 11, 2023 20:36

manoelcampos marked this pull request as ready for review May 11, 2023 20:40

manoelcampos merged commit 8f18fbc into master May 11, 2023

manoelcampos deleted the issue-437 branch May 11, 2023 20:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix #437, #438 and #440#439

Fix #437, #438 and #440#439
manoelcampos merged 33 commits intomasterfrom
issue-437

manoelcampos commented May 10, 2023 •

edited

Loading

Uh oh!

codacy-production bot commented May 11, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

manoelcampos commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codacy-production bot commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

See your quality gate settings Change summary preferences

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

manoelcampos commented May 10, 2023 •

edited

Loading

codacy-production bot commented May 11, 2023 •

edited

Loading