fix(scalar): Use appendTime instead of UnixMicro#986
Closed
erezrokah wants to merge 1 commit intocloudquery:mainfrom
Closed
fix(scalar): Use appendTime instead of UnixMicro#986erezrokah wants to merge 1 commit intocloudquery:mainfrom
appendTime instead of UnixMicro#986erezrokah wants to merge 1 commit intocloudquery:mainfrom
Conversation
disq
approved these changes
Jun 23, 2023
⏱️ Benchmark resultsComparing with ade3b63
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
=======================================
Coverage 52.81% 52.82%
=======================================
Files 62 62
Lines 6337 6338 +1
=======================================
+ Hits 3347 3348 +1
Misses 2685 2685
Partials 305 305
☔ View full report in Codecov by Sentry. |
candiduslynx
approved these changes
Jun 26, 2023
Member
|
This fix was included in #1064 but not the new test. |
Member
|
Fully merged as of #1071 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discovered while working on cloudquery/cloudquery#11719. Using
UnixMicro()is incorrect as it doesn't account for the internal time unit of the arrow timestamp type.AppendTimedoes https://github.com/cloudquery/arrow/blob/0d1f7234124e67b98b3aa0aa3e521d42c2f3165d/go/arrow/array/timestamp.go#L156 and does the correct conversion https://github.com/cloudquery/arrow/blob/8366a2241e66a53ee05ab4a832927e33e5f9c5a2/go/arrow/datatype_fixedwidth.go#L202Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)