Skip to content

fix: Transform []any as JSON#906

Merged
candiduslynx merged 1 commit intocloudquery:mainfrom
disq:fix/transform-slice-of-any-to-json
May 26, 2023
Merged

fix: Transform []any as JSON#906
candiduslynx merged 1 commit intocloudquery:mainfrom
disq:fix/transform-slice-of-any-to-json

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented May 26, 2023

Without this, attempting to transform an []any column results in panic:

panic: failed to transform table vercel_teams: failed to add column for field Profiles: failed to transform type for field Profiles: unsupported type: interface

Which is different from v2 behavior.

@disq disq requested a review from yevgenypats as a code owner May 26, 2023 13:32
@github-actions github-actions bot added fix and removed fix labels May 26, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (6b40d3b) 47.60% compared to head (b7a88c2) 47.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
+ Coverage   47.60%   47.62%   +0.02%     
==========================================
  Files          55       55              
  Lines        5132     5134       +2     
==========================================
+ Hits         2443     2445       +2     
  Misses       2426     2426              
  Partials      263      263              
Impacted Files Coverage Δ
transformers/struct.go 72.99% <100.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Copy Markdown

⏱️ Benchmark results

Comparing with 6b40d3b

  • DefaultConcurrencyDFS-2 resources/s: 10,015 ⬇️ 5.33% decrease vs. 6b40d3b
  • DefaultConcurrencyRoundRobin-2 resources/s: 12,496 ⬆️ 11.58% increase vs. 6b40d3b
  • Glob-2 ns/op: 273.1 ⬆️ 28.34% increase vs. 6b40d3b
  • TablesWithChildrenDFS-2 resources/s: 23,878 ⬇️ 20.19% decrease vs. 6b40d3b
  • TablesWithChildrenRoundRobin-2 resources/s: 23,186 ⬇️ 23.08% decrease vs. 6b40d3b
  • TablesWithRateLimitingDFS-2 resources/s: 28.41 ⬇️ 0.39% decrease vs. 6b40d3b
  • TablesWithRateLimitingRoundRobin-2 resources/s: 856.9 ⬆️ 2.52% increase vs. 6b40d3b

@disq disq added the automerge label May 26, 2023
@candiduslynx candiduslynx merged commit 7719677 into cloudquery:main May 26, 2023
@disq disq deleted the fix/transform-slice-of-any-to-json branch May 26, 2023 13:43
candiduslynx pushed a commit that referenced this pull request May 26, 2023
🤖 I have created a release *beep* *boop*
---


##
[3.6.5](v3.6.4...v3.6.5)
(2023-05-26)


### Bug Fixes

* Transform `[]any` as `JSON`
([#906](#906))
([7719677](7719677))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants