chore(tests): Ensure interface contract between types.XArray.ValueStr & types.XBuilder.AppendValueFromString#849
Merged
kodiakhq[bot] merged 2 commits intomainfrom May 8, 2023
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
+ Coverage 47.09% 47.61% +0.52%
==========================================
Files 76 76
Lines 7857 7865 +8
==========================================
+ Hits 3700 3745 +45
+ Misses 3654 3615 -39
- Partials 503 505 +2
☔ View full report in Codecov by Sentry. |
⏱️ Benchmark results
|
types.XArray.ValueStr & types.XBuilder.AppendValueFromStringtypes.XArray.ValueStr & types.XBuilder.AppendValueFromString
types.XArray.ValueStr & types.XBuilder.AppendValueFromStringtypes.XArray.ValueStr & types.XBuilder.AppendValueFromString
yevgenypats
suggested changes
May 8, 2023
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good.
Nit: let's create one test TestValueStrRoundTrip and make it table driven - seems code is exactly the same in all tests.
yevgenypats
approved these changes
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to apache/arrow#35457
BEGIN_COMMIT_OVERRIDE
chore(tests): Ensure interface contract between
types.XArray.ValueStr&types.XBuilder.AppendValueFromString(#849)feat(arrow): Add
types.XBuilder.NewXArrayhelpersEND_COMMIT_OVERRIDE