feat: Move proto to external repository#844
Conversation
⏱️ Benchmark results
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
- Coverage 47.81% 46.72% -1.10%
==========================================
Files 76 59 -17
Lines 7865 6583 -1282
==========================================
- Hits 3761 3076 -685
+ Misses 3599 3106 -493
+ Partials 505 401 -104
☔ View full report in Codecov by Sentry. |
| if err := json.Unmarshal(resourceB, &resource); err != nil { | ||
| t.Fatalf("failed to unmarshal resource: %v", err) | ||
| if err := json.Unmarshal(r.Resource, &resource); err != nil { | ||
| t.Fatal(err) |
There was a problem hiding this comment.
| t.Fatal(err) | |
| t.Fatalf("failed to unmarshal resource: %v", err) |
| if err != nil { | ||
| t.Fatalf("Failed to dial bufnet: %v", err) | ||
| } | ||
| c, err := clients.NewClient(ctx, specs.RegistryGrpc, "", "", clients.WithGRPCConnection(conn), clients.WithNoSentry()) |
There was a problem hiding this comment.
How does the --no-sentry option get passed to the plugins now? 🤔
There was a problem hiding this comment.
I guess the code for managing the plugins will now live in the CLI?
There was a problem hiding this comment.
For the test because it's already running sentry is not relevant here.
| if err := json.Unmarshal(resourceB, &resource); err != nil { | ||
| t.Fatalf("failed to unmarshal resource: %v", err) | ||
| if err := json.Unmarshal(r.Resource, &resource); err != nil { | ||
| t.Fatal(err) |
There was a problem hiding this comment.
| t.Fatal(err) | |
| t.Fatalf("failed to unmarshal resource: %v", err) |
There was a problem hiding this comment.
because it's just test then I prefer to to add formatting because it printing the line anyway.
There was a problem hiding this comment.
some places had formatting and some didn't so I tried to make it consistent without formatting in test and just call t.Fatal
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
hermanschaaf
left a comment
There was a problem hiding this comment.
Haven't tested it myself yet, but looks good from a read-through. Nothing too scary :)
🤖 I have created a release *beep* *boop* --- ## [2.6.0](v2.5.4...v2.6.0) (2023-05-08) ### Features * **arrow:** Add `types.XBuilder.NewXArray` helpers ([2df4413](2df4413)) * Move proto to external repository ([#844](#844)) ([3cd3ba7](3cd3ba7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This removes protobuf files and generated code to https://github.com/cloudquery/plugin-pb/ and https://github.com/cloudquery/plugin-pb-go/.
This will make it possible for the CLI not import the plugin-sdk (any other clients) as well as decouple version upgrade from protobuf updates and SDK updates.
This is ready for first review but Im still working on a PR for the CLI to test that it all works properly before merging.