feat: Add WithResolverTransformer#578
Merged
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom Jan 5, 2023
Merged
Conversation
⏱️ Benchmark results
|
disq
approved these changes
Jan 5, 2023
yevgenypats
approved these changes
Jan 5, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
🤖 I have created a release *beep* *boop* --- ## [1.22.0](v1.21.0...v1.22.0) (2023-01-06) ### Features * Add size in bytes to CQ types ([#510](#510)) ([7c15d9a](7c15d9a)) * Add WithIgnoreInTestsTransformer ([#579](#579)) ([f836abd](f836abd)) * Add WithResolverTransformer ([#578](#578)) ([5aeba0e](5aeba0e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jan 9, 2023
#### Summary This PR removes code gen from GCP (it keeps only service discovery). Blocked by cloudquery/plugin-sdk#578 and cloudquery/plugin-sdk#579. While working on this PR I noticed a few cases where we configured the wrong PKs on tables. I'll fix those separately <!--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For some plugins it's useful to configure a resolver based on the field's type:
https://github.com/cloudquery/cloudquery/blob/876cc163d6dff277bb09a5147162a8646fcd98de/plugins/source/gcp/codegen/main.go#L263
I don't use the default one from
codegenpackage like others as it returns(string, error)and we want to return aschema.ColumnResolverinsteadUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)