feat: Add unwrap option to transformations#573
Merged
kodiakhq[bot] merged 1 commit intomainfrom Jan 5, 2023
Merged
Conversation
⏱️ Benchmark resultsComparing with d89a911
|
erezrokah
approved these changes
Jan 5, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks good, maybe we can do another PR to add the WithPrimaryKeys option?
Contributor
Author
I want to avoid it for now. The way to override in the paradaigm is just to enter it manually in the column otherwise we will end up |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
🤖 I have created a release *beep* *boop* --- ## [1.19.0](v1.18.0...v1.19.0) (2023-01-05) ### Features * Add scheduler option and introduce Round Robin scheduler ([#545](#545)) ([d89a911](d89a911)) * Add unwrap option to transformations ([#573](#573)) ([a17ee4b](a17ee4b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
yevgenypats
added a commit
to cloudquery/cloudquery
that referenced
this pull request
Jan 9, 2023
Similar to #6276 moving transformation to be part of our SDK cloudquery/plugin-sdk#564 This is related to cloudquery/plugin-sdk#573 Few notes on column changes: most of changes are just additional columns and this should be fine as we did too much transformation. we want to keep the code simple, focus on extraction and provide and easy way of doing "dumb" one level transformation via reflection. The additional column are because we have in some places a duplicate where we add our own `arn` so it can be consistent but this is our decision and we still want to be as close as possible to the API so some duplicates is fine (and it makes the code simple and consistent). breaking changes in `aws_docdb_pending_maintenance_actions ` those apparently never worked and those columns where always empty (they didn't have mock tests so we didn't catch those) Co-authored-by: Kemal <223029+disq@users.noreply.github.com> Co-authored-by: Kemal Hadimli <disq@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on transformation. Adding unwrap option as needed in some cases where we create our own wrapper struct.
This also moves the tests from codegen.