Skip to content

fix(testing): Sort results before comparison in tests #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 1 commit into from
Jan 2, 2023
Merged

fix(testing): Sort results before comparison in tests #561

kodiakhq merged 1 commit into from
Jan 2, 2023

Conversation

@hermanschaaf
Copy link
Member

@hermanschaaf hermanschaaf commented Jan 2, 2023 •
edited
Loading

Extracted from #542 to allow us to fix cloudquery/cloudquery#6069

Before this change, running cockroachDB tests:

Jan  2 11:03:08.760000 INF Query args=["testAppendSource474bca19-69ba-4a5a-8af0-3d890198a243"] commandTag="SELECT 2" module=pgx pid=1570743 sql="SELECT * FROM \"cq_test_write_append\" WHERE _cq_source_name = $1 order by _cq_sync_time asc"
--- FAIL: TestPgPlugin (0.36s)
    --- FAIL: TestPgPlugin/TestWriteOverwrite (0.22s)
        client_test.go:20: expected first resource diff: value at 2 is(d1ebd2a374f14556852c4d5b23608201) TypeUUID while other is(3da5b2eafc814ecb973bcee770bb70e1) TypeUUID
            value at 3 is(d03dd7f8781a4dbb93aaebefb6aaba87) TypeUUID while other is(f16b7d3a0f85441daf30da5d2d8afb26) TypeUUID
            value at 7 is(758c419b5a1b4a46ba45499b402c6aaf) TypeUUID while other is(0f252e92137b4f55a856cbf97d43d098) TypeUUID

FAIL
FAIL	github.com/cloudquery/cloudquery/plugins/destination/postgresql/client	0.640s

After this change:

ok  	github.com/cloudquery/cloudquery/plugins/destination/postgresql/client	0.662s

@github-actions github-actions bot added fix and removed fix labels Jan 2, 2023
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

⏱️ Benchmark results

Comparing with b1e8528

  • DefaultConcurrency-2 resources/s: 12,129 ⬆️ 3.47% increase vs. b1e8528
  • Glob-2 ns/op: 181.7 ⬇️ 6.00% decrease vs. b1e8528
  • TablesWithChildrenDefaultConcurrency-2 resources/s: 30,651 ⬆️ 2.30% increase vs. b1e8528
  • BufferedScanner-2 ns/op: 11.11 ⬇️ 9.27% decrease vs. b1e8528
  • LogReader-2 ns/op: 34.42 ⬇️ 3.08% decrease vs. b1e8528

erezrokah
erezrokah approved these changes Jan 2, 2023
View reviewed changes
@yevgenypats
Copy link
Contributor

yevgenypats commented Jan 2, 2023

Nice!

@kodiakhq kodiakhq bot merged commit 587715d into main Jan 2, 2023
@kodiakhq kodiakhq bot deleted the update-testing branch January 2, 2023 12:21
@cq-bot cq-bot mentioned this pull request Jan 2, 2023
Merged
erezrokah pushed a commit that referenced this pull request Jan 3, 2023
@cq-bot
chore(main): Release v1.17.0 (#562)
68e2af3 
🤖 I have created a release *beep* *boop*
---


##
[1.17.0](v1.16.1...v1.17.0)
(2023-01-02)


### Features

* Add primary key validation
([#563](#563))
([09f891a](09f891a))


### Bug Fixes

* **testing:** Sort results before comparison in tests
([#561](#561))
([587715d](587715d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@erezrokah erezrokah mentioned this pull request Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erezrokah erezrokah erezrokah approved these changes

+1 more reviewer

@yevgenypats yevgenypats yevgenypats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CockroachDB destination tests are failing

4 participants

@hermanschaaf @yevgenypats @erezrokah