feat(destinations): Add BatchSize method to ManagedWriter interface#539
Closed
erezrokah wants to merge 1 commit intocloudquery:mainfrom
Closed
feat(destinations): Add BatchSize method to ManagedWriter interface#539erezrokah wants to merge 1 commit intocloudquery:mainfrom
erezrokah wants to merge 1 commit intocloudquery:mainfrom
Conversation
⏱️ Benchmark resultsComparing with e4bfc37
|
5 tasks
90f68da to
445f8b4
Compare
Member
Author
|
Replaced by #540 |
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 28, 2022
Replaces #539. Keeps batch size on the top level spec, but allows plugins to override it ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch size should be configured at the plugin level spec (see https://www.cloudquery.io/docs/plugins/destinations/bigquery/overview#bigquery-spec).
This PR adds a
BatchSizeinterface method to be called by the managed writer.This can't be done via a plugin option, as we read the plugin spec after the plugin is created (options are passed on creation)
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)