chore(go): Rename interface{} to any for readability#517
Merged
candiduslynx merged 2 commits intomainfrom Dec 20, 2022
Merged
Conversation
⏱️ Benchmark resultsComparing with cb7d2ad
|
erezrokah
approved these changes
Dec 19, 2022
Member
erezrokah
left a comment
There was a problem hiding this comment.
This looks good to me, but maybe we should have a lint rule for it?
Contributor
Author
|
They are interchangeable. Also gen code (see |
Member
I mean if we chose one or the other (mostly for style I think) we should enforce it so our codebase is consistent. |
a2feddc to
aee6a8d
Compare
Contributor
Author
|
@erezrokah |
f7e2a86 to
be53e76
Compare
be53e76 to
27d4245
Compare
hermanschaaf
approved these changes
Dec 20, 2022
yevgenypats
approved these changes
Dec 20, 2022
erezrokah
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Dec 20, 2022
daniel-garcia
pushed a commit
to infobloxopen/ibcq-source-k8s
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anyis an alias tointerface{}introduced in Go 1.18. It's shorter and using it instead ofinterface{}improves readability a lot.Marking this PR as a chore, as the functionality is left intact.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)