Skip to content

fix: Use json.Valid#500

Merged
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom
erezrokah:fix/json_validation
Dec 14, 2022
Merged

fix: Use json.Valid#500
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom
erezrokah:fix/json_validation

Conversation

@erezrokah
Copy link
Copy Markdown
Member

Summary

So we support more types like arrays, strings, etc.


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 14, 2022

⏱️ Benchmark results

Comparing with 9a9f46e

  • DefaultConcurrency-2 resources/s: 12,077 ⬆️ 1.73% increase vs. 9a9f46e
  • Glob-2 ns/op: 157.8 (no change)
  • TablesWithChildrenDefaultConcurrency-2 resources/s: 30,372 ⬇️ 1.92% decrease vs. 9a9f46e
  • BufferedScanner-2 ns/op: 9.384 ⬆️ 0.05% increase vs. 9a9f46e
  • LogReader-2 ns/op: 30.72 ⬆️ 0.03% increase vs. 9a9f46e

@kodiakhq kodiakhq bot merged commit 4242e5e into cloudquery:main Dec 14, 2022
kodiakhq bot pushed a commit that referenced this pull request Dec 14, 2022
🤖 I have created a release *beep* *boop*
---


## [1.12.4](v1.12.3...v1.12.4) (2022-12-14)


### Bug Fixes

* Use json.Valid ([#500](#500)) ([4242e5e](4242e5e))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants