feat: Add handling for json.Number in faker by hermanschaaf · Pull Request #481 · cloudquery/plugin-sdk

hermanschaaf · 2022-12-09T20:32:25Z

When faking data, it is useful if json.Number is faked with a number, otherwise json marshalling fails later with "test string" is not a number.

github-actions · 2022-12-09T20:35:50Z

⏱️ Benchmark results

Comparing with cdcef5d

DefaultConcurrency-2 resources/s: 11,460 ⬇️ 4.91% decrease vs. cdcef5d
Glob-2 ns/op: 161 ⬇️ 29.38% decrease vs. cdcef5d
TablesWithChildrenDefaultConcurrency-2 resources/s: 30,269 ⬆️ 11.72% increase vs. cdcef5d
BufferedScanner-2 ns/op: 9.408 ⬇️ 36.05% decrease vs. cdcef5d
LogReader-2 ns/op: 30.73 ⬇️ 30.65% decrease vs. cdcef5d

🤖 I have created a release *beep* *boop* --- ## [1.12.0](v1.11.2...v1.12.0) (2022-12-11) ### Features * Add handling for json.Number in faker ([#481](#481)) ([ad20787](ad20787)) ### Bug Fixes * Allow both 'yml' and 'yaml' extensions ([#476](#476)) ([52c4c56](52c4c56)) * **errors:** Remove usage of `codes.Internal` ([#485](#485)) ([62692b9](62692b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

feat: Add handling for json.Number in faker

c2d5adc

hermanschaaf requested a review from yevgenypats as a code owner December 9, 2022 20:32

github-actions bot added the feat label Dec 9, 2022

yevgenypats approved these changes Dec 9, 2022

View reviewed changes

hermanschaaf added the automerge label Dec 9, 2022

kodiakhq bot merged commit ad20787 into main Dec 9, 2022

kodiakhq bot deleted the json-number branch December 9, 2022 20:40

cq-bot mentioned this pull request Dec 9, 2022

chore(main): Release v1.12.0 #482

Merged