refactor: Simplify IsUnimplemented#478
Closed
erezrokah wants to merge 3 commits intocloudquery:mainfrom
Closed
Conversation
⏱️ Benchmark resultsComparing with 62692b9
|
5 tasks
candiduslynx
approved these changes
Dec 21, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 24, 2022
Similar to #478. `status.Convert` calls `FromError` internally. Some notes: 1. No need to check `s != nil` as `status.Convert` always returns a non `nil` value if `err != nil` 2. `FromError` returns `false` if `err` is not a gRPC error. This can never happen in this case. Also I believe the `failed to call GetProtocolVersion` is wrong as it should be `err is not a gRPC error`. Regardless I don't think we need it ---
Member
Author
|
Closing as stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We can simplify this using
status.Covert.Also gRPC doesn't wrap errors so I don't think we need the recursionKept the recursion as we are the ones doing wrapping of errors in
plugin-sdk/clients/source.go
Line 259 in 62692b9
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)