Merged
Conversation
Contributor
Author
|
Still testing this |
erezrokah
requested changes
Dec 7, 2022
Member
erezrokah
left a comment
There was a problem hiding this comment.
The fix looks good, but I won't kill the process because we can't send metrics. Maybe only log it?
Contributor
Author
It's debugging :) |
Contributor
Author
|
I think there were number of issues here and after fixing the initial issue with making sure |
⏱️ Benchmark resultsComparing with e34cb2c
|
erezrokah
reviewed
Dec 8, 2022
| tables schema.Tables | ||
| // status sync metrics | ||
| metrics SourceMetrics | ||
| metrics *SourceMetrics |
Member
There was a problem hiding this comment.
Is this change to a pointer required for the fix?
erezrokah
approved these changes
Dec 8, 2022
hermanschaaf
approved these changes
Dec 8, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
🤖 I have created a release *beep* *boop* --- ## [1.11.2](v1.11.1...v1.11.2) (2022-12-08) ### Bug Fixes * Initialise clients only once ([#473](#473)) ([c88a521](c88a521)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Dec 8, 2022
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Dec 8, 2022
#### Summary An AWS sanity test that to catch cloudquery/cloudquery-issues#459 (internal issue). Related PR cloudquery/plugin-sdk#473. Only runs on release PRs <!--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix a panic that was caused if plugins misbehave and return difference results for difference runs with the same config.