feat: Add Support for net.IP in Faker#445
Merged
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom Dec 5, 2022
Merged
Conversation
⏱️ Benchmark results
|
erezrokah
approved these changes
Nov 30, 2022
erezrokah
reviewed
Nov 30, 2022
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
yevgenypats
suggested changes
Dec 2, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
doesn't that produce a valid IP only for for slice? what about map, ptr or just field in struct ?
Contributor
|
Or maybe I miss something as seems the tests does pass? didn't touch that code for a while.... |
Contributor
Author
|
yevgenypats
approved these changes
Dec 5, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
🤖 I have created a release *beep* *boop* --- ## [1.11.0](v1.10.0...v1.11.0) (2022-12-05) ### Features * Add Support for net.IP in Faker ([#445](#445)) ([2deced1](2deced1)) ### Bug Fixes * **deps:** Update golang.org/x/exp digest to 6ab00d0 ([#449](#449)) ([b981e33](b981e33)) * **deps:** Update module github.com/avast/retry-go/v4 to v4.3.1 ([#450](#450)) ([e4116f1](e4116f1)) * **deps:** Update module google.golang.org/grpc to v1.51.0 ([#451](#451)) ([538211c](538211c)) * Don't log start-and-finish of relational tables ([#459](#459)) ([4d6eeca](4d6eeca)) * Sync Metrics for Long running plugins ([#455](#455)) ([3fecc61](3fecc61)) * TablesForSpec should only return top-level tables ([#456](#456)) ([ab7ca97](ab7ca97)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Gitlab Plugin I am working on has
net.IPfields... existing implementation does not produce a valid IP address so needs explicit supportUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)