Skip to content

fix: Skip very large gRPC messages, log when it happens#421

Merged
hermanschaaf merged 2 commits intomainfrom
grpc-max-size
Nov 22, 2022
Merged

fix: Skip very large gRPC messages, log when it happens#421
hermanschaaf merged 2 commits intomainfrom
grpc-max-size

Conversation

@hermanschaaf
Copy link
Copy Markdown
Contributor

Context: cloudquery/cloudquery#4834

This change:

  • bumps the gRPC max message size from 50MiB to 100MiB
  • logs the name of the table to Sentry when we see a message over 50MiB
  • logs to the user if we drop a message because it exceeds 100MiB

@github-actions github-actions bot added the fix label Nov 22, 2022
@hermanschaaf hermanschaaf changed the title fix: Skip very large GRPC messages, log when it happens fix: Skip very large gRPC messages, log when it happens Nov 22, 2022
@github-actions github-actions bot added fix and removed fix labels Nov 22, 2022
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@hermanschaaf hermanschaaf merged commit 0874d58 into main Nov 22, 2022
@hermanschaaf hermanschaaf deleted the grpc-max-size branch November 22, 2022 10:41
kodiakhq bot pushed a commit that referenced this pull request Nov 22, 2022
Reverts #416

Nothing wrong with it as far as we know, but we want to release it separately from #421
kodiakhq bot pushed a commit that referenced this pull request Nov 22, 2022
🤖 I have created a release *beep* *boop*
---


## [1.7.0](v1.6.0...v1.7.0) (2022-11-22)

### Bug Fixes

* Skip very large gRPC messages, log when it happens ([#421](#421)) ([0874d58](0874d58))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants