fix: Require Row count to be greater than 0#2259
Merged
kodiakhq[bot] merged 2 commits intomainfrom Aug 18, 2025
Merged
Conversation
stoovon
approved these changes
Aug 18, 2025
hermanschaaf
approved these changes
Aug 18, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
🤖 I have created a release *beep* *boop* --- ## [4.89.0](v4.88.1...v4.89.0) (2025-08-19) ### Features * Make getColumnChangeSummary public for use in plugins ([#2260](#2260)) ([5c0a06e](5c0a06e)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#2256](#2256)) ([0b64895](0b64895)) * **deps:** Update aws-sdk-go-v2 monorepo ([#2257](#2257)) ([b546297](b546297)) * **deps:** Update golang.org/x/exp digest to 645b1fa ([#2250](#2250)) ([ab469c1](ab469c1)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.14.0 ([#2246](#2246)) ([291b0d9](291b0d9)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.14.1 ([#2254](#2254)) ([fb148a1](fb148a1)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.16 ([#2245](#2245)) ([5223700](5223700)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.17 ([#2248](#2248)) ([3b8a166](3b8a166)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.18 ([#2249](#2249)) ([8e35433](8e35433)) * **deps:** Update module github.com/grpc-ecosystem/go-grpc-middleware/v2 to v2.3.2 ([#2251](#2251)) ([a76d1c2](a76d1c2)) * **deps:** Update module github.com/spf13/cobra to v1.9.1 ([#2252](#2252)) ([3db1576](3db1576)) * **deps:** Update module google.golang.org/grpc to v1.74.2 ([#2255](#2255)) ([5d8368f](5d8368f)) * **deps:** Update module google.golang.org/protobuf to v1.36.7 ([#2258](#2258)) ([cd611d3](cd611d3)) * Require Row count to be greater than 0 ([#2259](#2259)) ([8721bdc](8721bdc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently when we send usage we iterate over all possible tables. In cases where a table had a non 0 value earlier in the sync it is still included in every subsequent report. This leads us to have large numbers of
row_count = 0records in our DBThis change will eliminate the SDK from sending these records