Merged
Conversation
erezrokah
approved these changes
Aug 30, 2022
|
|
||
| import "testing" | ||
|
|
||
| func TestResource(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Empty test file - let's either put some assertions or delete the file so it doesn't look like there is test coverage for resource.go?
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
…2055) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/apache/arrow-go/v18](https://togithub.com/apache/arrow-go) | require | minor | `v18.0.0` -> `v18.1.0` | --- ### Release Notes <details> <summary>apache/arrow-go (github.com/apache/arrow-go/v18)</summary> ### [`v18.1.0`](https://togithub.com/apache/arrow-go/releases/tag/v18.1.0): Apache Arrow Go v18.1.0 [Compare Source](https://togithub.com/apache/arrow-go/compare/v18.0.0...v18.1.0) ##### What's Changed - [GH-19](https://togithub.com/apache/arrow-go/issues/19): Add Code Of Conduct by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/161](https://togithub.com/apache/arrow-go/pull/161) - [GH-22](https://togithub.com/apache/arrow-go/issues/22): Add issue template by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/163](https://togithub.com/apache/arrow-go/pull/163) - [GH-26](https://togithub.com/apache/arrow-go/issues/26): Add Codeowners by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/160](https://togithub.com/apache/arrow-go/pull/160) - Bump github.com/hamba/avro/v2 from 2.26.0 to 2.27.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/166](https://togithub.com/apache/arrow-go/pull/166) - [GH-41](https://togithub.com/apache/arrow-go/issues/41): \[Array] Make String and Binary consistent by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/165](https://togithub.com/apache/arrow-go/pull/165) - fix(arrow/compute): fix scenario where prealloc output is missed by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/167](https://togithub.com/apache/arrow-go/pull/167) - fix: don't clobber saved frame pointer in arm64 assembly functions by [@​nsrip-dd](https://togithub.com/nsrip-dd) in [https://github.com/apache/arrow-go/pull/170](https://togithub.com/apache/arrow-go/pull/170) - fix(parquet): Reading UUID columns by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/173](https://togithub.com/apache/arrow-go/pull/173) - fix(arrow/compute): compare kernels with UUID by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/174](https://togithub.com/apache/arrow-go/pull/174) - [GH-23](https://togithub.com/apache/arrow-go/issues/23): Add PR template by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/164](https://togithub.com/apache/arrow-go/pull/164) - ci: add self-assignable issues by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/176](https://togithub.com/apache/arrow-go/pull/176) - feat(arrow/compute): Implement kernel for "not" function by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/178](https://togithub.com/apache/arrow-go/pull/178) - Bump actions/checkout from 4.2.1 to 4.2.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/179](https://togithub.com/apache/arrow-go/pull/179) - Bump actions/setup-python from 5.2.0 to 5.3.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/180](https://togithub.com/apache/arrow-go/pull/180) - fix(arrow/cdata): handle export struct with no fields by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/175](https://togithub.com/apache/arrow-go/pull/175) - Bump actions/setup-go from 5.0.2 to 5.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/181](https://togithub.com/apache/arrow-go/pull/181) - feat(arrow/compute): make is_nan dispatchable by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/177](https://togithub.com/apache/arrow-go/pull/177) - [GH-20](https://togithub.com/apache/arrow-go/issues/20): Add CONTRIBUTING.md by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/162](https://togithub.com/apache/arrow-go/pull/162) - chore: Bump github.com/substrait-io/substrait-go from 1.1.0 to 1.2.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/183](https://togithub.com/apache/arrow-go/pull/183) - chore: Bump golang.org/x/sync from 0.8.0 to 0.9.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/189](https://togithub.com/apache/arrow-go/pull/189) - chore: Bump github.com/klauspost/cpuid/v2 from 2.2.8 to 2.2.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/188](https://togithub.com/apache/arrow-go/pull/188) - chore: Bump golang.org/x/tools from 0.26.0 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/186](https://togithub.com/apache/arrow-go/pull/186) - chore: bump google.golang.org/grpc from 1.67.1 to 1.68.0 by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/190](https://togithub.com/apache/arrow-go/pull/190) - feat(arrow/cdata): Add Implementation of Async C Data interface by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/169](https://togithub.com/apache/arrow-go/pull/169) - chore: Bump google.golang.org/protobuf from 1.35.1 to 1.35.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/192](https://togithub.com/apache/arrow-go/pull/192) - fix(arrow/memory/internal/cgoalloc): Remove usage of reflect.SliceHeader by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/194](https://togithub.com/apache/arrow-go/pull/194) - ci: update pkg-config to pkgconf on Homebrew by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/198](https://togithub.com/apache/arrow-go/pull/198) - ci: use correct GitHub Actions permission "contents" instead of "content" by [@​raulcd](https://togithub.com/raulcd) in [https://github.com/apache/arrow-go/pull/200](https://togithub.com/apache/arrow-go/pull/200) - feat(arrow/ipc): add functions to generate payloads by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/196](https://togithub.com/apache/arrow-go/pull/196) - fix(internal/json): add arrow_json_stdlib build tag by [@​toddtreece](https://togithub.com/toddtreece) in [https://github.com/apache/arrow-go/pull/199](https://togithub.com/apache/arrow-go/pull/199) - chore: Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/201](https://togithub.com/apache/arrow-go/pull/201) - feat(parquet/pqarrow): Add ForceLarge option by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/197](https://togithub.com/apache/arrow-go/pull/197) - chore: Bump golang.org/x/sys from 0.27.0 to 0.28.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/212](https://togithub.com/apache/arrow-go/pull/212) - chore: Bump golang.org/x/tools from 0.27.0 to 0.28.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/214](https://togithub.com/apache/arrow-go/pull/214) - chore: Bump google.golang.org/grpc from 1.68.0 to 1.68.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/213](https://togithub.com/apache/arrow-go/pull/213) - fix(parquet/metadata): fix default unsigned int statistics by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/210](https://togithub.com/apache/arrow-go/pull/210) - chore: bump github.com/goccy/go-json to v0.10.4 by [@​toddtreece](https://togithub.com/toddtreece) in [https://github.com/apache/arrow-go/pull/218](https://togithub.com/apache/arrow-go/pull/218) - feat(parquet): Move footerOffset into FileMetaData by [@​joechenrh](https://togithub.com/joechenrh) in [https://github.com/apache/arrow-go/pull/217](https://togithub.com/apache/arrow-go/pull/217) - chore: Bump actions/setup-go from 5.1.0 to 5.2.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/219](https://togithub.com/apache/arrow-go/pull/219) - chore: Bump github.com/pierrec/lz4/v4 from 4.1.21 to 4.1.22 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/220](https://togithub.com/apache/arrow-go/pull/220) - chore: Bump google.golang.org/grpc from 1.68.1 to 1.69.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/221](https://togithub.com/apache/arrow-go/pull/221) - feat(arrow/ipc): implement lazy loading/zero-copy for IPC files by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/216](https://togithub.com/apache/arrow-go/pull/216) - chore: Bump google.golang.org/protobuf from 1.35.2 to 1.36.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/222](https://togithub.com/apache/arrow-go/pull/222) - chore: Bump google.golang.org/protobuf from 1.36.0 to 1.36.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/226](https://togithub.com/apache/arrow-go/pull/226) - chore: Bump actions/upload-artifact from 4.4.3 to 4.5.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/228](https://togithub.com/apache/arrow-go/pull/228) - chore: Bump github.com/google/flatbuffers from 24.3.25+incompatible to 24.12.23+incompatible by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/229](https://togithub.com/apache/arrow-go/pull/229) - chore: Bump google.golang.org/grpc from 1.69.0 to 1.69.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/227](https://togithub.com/apache/arrow-go/pull/227) - chore(arrow/compute/expr): upgrade substrait-go by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/234](https://togithub.com/apache/arrow-go/pull/234) - chore: Bump github.com/substrait-io/substrait-go/v3 from 3.2.0 to 3.2.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/237](https://togithub.com/apache/arrow-go/pull/237) - chore: Bump golang.org/x/tools from 0.28.0 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/apache/arrow-go/pull/235](https://togithub.com/apache/arrow-go/pull/235) - chore: Update the project URL in apache/arrow-go by [@​kou](https://togithub.com/kou) in [https://github.com/apache/arrow-go/pull/239](https://togithub.com/apache/arrow-go/pull/239) - chore: Enable Java integration test by [@​kou](https://togithub.com/kou) in [https://github.com/apache/arrow-go/pull/240](https://togithub.com/apache/arrow-go/pull/240) - feat(parquet): Add support for Page Indexes by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/223](https://togithub.com/apache/arrow-go/pull/223) - chore: bump version by [@​zeroshade](https://togithub.com/zeroshade) in [https://github.com/apache/arrow-go/pull/241](https://togithub.com/apache/arrow-go/pull/241) ##### New Contributors - [@​nsrip-dd](https://togithub.com/nsrip-dd) made their first contribution in [https://github.com/apache/arrow-go/pull/170](https://togithub.com/apache/arrow-go/pull/170) - [@​toddtreece](https://togithub.com/toddtreece) made their first contribution in [https://github.com/apache/arrow-go/pull/199](https://togithub.com/apache/arrow-go/pull/199) - [@​joechenrh](https://togithub.com/joechenrh) made their first contribution in [https://github.com/apache/arrow-go/pull/217](https://togithub.com/apache/arrow-go/pull/217) **Full Changelog**: apache/arrow-go@v18.0.0...v18.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)