Merged
Conversation
murarustefaan
approved these changes
Mar 7, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
🤖 I have created a release *beep* *boop* --- ## [4.74.1](v4.74.0...v4.74.1) (2025-03-07) ### Bug Fixes * Revert faker pointer change ([#2093](#2093)) ([4157755](4157755)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts https://github.com/cloudquery/plugin-sdk/pull/2087/files#diff-d23bd4e64abe4e710bc1f39711bda2ddc0d4a9a5c1ee80e7551787a0f81e2d5aL20 as it broke some plugins tests.
Underlying issue is that we call
getFakedValueon the array of fields inplugin-sdk/faker/faker.go
Line 65 in 1298b36
Reverting for now so it doesn't block the SDK update
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)