Skip to content

fix: Validate missing PK components#2037

Merged
erezrokah merged 1 commit intomainfrom
fix/detect_missing_pk_components
Dec 24, 2024
Merged

fix: Validate missing PK components#2037
erezrokah merged 1 commit intomainfrom
fix/detect_missing_pk_components

Conversation

@erezrokah
Copy link
Copy Markdown
Member

Summary

Fixes https://github.com/cloudquery/cloudquery-issues/issues/3004


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@erezrokah erezrokah requested review from a team, bbernays and ronsh12 December 23, 2024 17:47
@github-actions github-actions bot added the fix label Dec 23, 2024
@erezrokah erezrokah merged commit d2cff6b into main Dec 24, 2024
@erezrokah erezrokah deleted the fix/detect_missing_pk_components branch December 24, 2024 09:35
erezrokah added a commit that referenced this pull request Jan 7, 2025
…ailure (#2039)

#### Summary

Follow up to #2037.
Gave it another thought and instead of erroring out might be better to
log a warning (for starts) so we can fix the issues instead of breaking
tables in the AWS plugin.

Even when a PK component has a null value CQ ID will still be calculated
with the null value, so the data can be inserted (opposed to a missing
PK where in the case of DB destinations the insertion will fail)

---

Use the following steps to ensure your PR is ready to be reviewed

- [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md)
🧑‍🎓
- [ ] Run `go fmt` to format your code 🖊
- [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint
[here](https://golangci-lint.run/usage/install/#local-installation))
- [ ] Update or add tests 🧪
- [ ] Ensure the status checks below are successful ✅
kodiakhq bot pushed a commit that referenced this pull request Jan 7, 2025
🤖 I have created a release *beep* *boop*
---


## [4.72.6](v4.72.5...v4.72.6) (2025-01-07)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.4 ([#2044](#2044)) ([c7bd2d2](c7bd2d2))
* **deps:** Update module github.com/goccy/go-json to v0.10.4 ([#2040](#2040)) ([f6e0201](f6e0201))
* **deps:** Update module google.golang.org/protobuf to v1.36.1 ([#2043](#2043)) ([13437c2](13437c2))
* **deps:** Update opentelemetry-go monorepo ([#2042](#2042)) ([e6123c3](e6123c3))
* Log warning instead of erroring out of PK component validation failure ([#2039](#2039)) ([c98b5c5](c98b5c5))
* Validate missing PK components ([#2037](#2037)) ([d2cff6b](d2cff6b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants