Skip to content

fix: Handle integer overflow#1996

Merged
erezrokah merged 1 commit intomainfrom
fix/int_casting
Dec 5, 2024
Merged

fix: Handle integer overflow#1996
erezrokah merged 1 commit intomainfrom
fix/int_casting

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah commented Dec 5, 2024

Summary

Fixes https://github.com/cloudquery/plugin-sdk/security/code-scanning/3
Fixes https://github.com/cloudquery/plugin-sdk/security/code-scanning/2
Fixes https://github.com/cloudquery/plugin-sdk/security/code-scanning/1

Technically a false positive since on 64 machines (we only compile to 64 bit) int and int64 (number is int64) usually have the same size so no overflow


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@erezrokah erezrokah requested review from a team, bbernays and ronsh12 December 5, 2024 17:10
@github-actions github-actions bot added the fix label Dec 5, 2024
@github-actions github-actions bot added fix and removed fix labels Dec 5, 2024
@erezrokah erezrokah merged commit 6af9c22 into main Dec 5, 2024
@erezrokah erezrokah deleted the fix/int_casting branch December 5, 2024 17:34
kodiakhq bot pushed a commit that referenced this pull request Dec 6, 2024
🤖 I have created a release *beep* *boop*
---


## [4.70.2](v4.70.1...v4.70.2) (2024-12-05)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.13.4 ([#1992](#1992)) ([cd4dc4b](cd4dc4b))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.25.5 ([#1991](#1991)) ([037a6d9](037a6d9))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.25.6 ([#1994](#1994)) ([32855ea](32855ea))
* Handle integer overflow ([#1996](#1996)) ([6af9c22](6af9c22))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants