feat: Add warning on duplicate clients for round-robin and shuffle schedulers#1878
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Aug 27, 2024
Merged
Conversation
erezrokah
approved these changes
Aug 26, 2024
Member
erezrokah
left a comment
There was a problem hiding this comment.
Thanks @kabachook looks great
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
🤖 I have created a release *beep* *boop* --- ## [4.61.0](v4.60.0...v4.61.0) (2024-09-02) ### Features * Add remoteoauth helpers (`TokenAuthTransport` and `TokenAuthEditor`) ([#1875](#1875)) ([bb1be84](bb1be84)) * Add warning on duplicate clients for `round-robin` and `shuffle` schedulers ([#1878](#1878)) ([d148b94](d148b94)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#1872](#1872)) ([80eb38a](80eb38a)) * **deps:** Update golang.org/x/exp digest to 9b4947d ([#1881](#1881)) ([bbeb846](bbeb846)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.27.30 ([#1876](#1876)) ([0319ff3](0319ff3)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.27.31 ([#1879](#1879)) ([4dc8f41](4dc8f41)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.12.8 ([#1870](#1870)) ([96a5194](96a5194)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.12.9 ([#1873](#1873)) ([76d4f9f](76d4f9f)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.13.0 ([#1874](#1874)) ([e091d8a](e091d8a)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.22.1 ([#1877](#1877)) ([11aaab4](11aaab4)) * **deps:** Update module golang.org/x/oauth2 to v0.22.0 ([#1883](#1883)) ([2a40306](2a40306)) * **deps:** Update module google.golang.org/grpc to v1.66.0 ([#1880](#1880)) ([a907ea6](a907ea6)) * **deps:** Update opentelemetry-go monorepo ([#1884](#1884)) ([9be63fe](9be63fe)) * Fix panic when converting schema changes to string ([#1885](#1885)) ([8274f17](8274f17)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiplex returned duplicate clientwarning for incorrect multiplexers occurs only whendfsscheduler is used. This PR adds the same warning forround-robinandshuffleschedulers.More context here: https://discord.com/channels/872925471417962546/1271466277189324831
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)