fix: Streaming to destination plugin wasn't implemented correctly#187
Merged
kodiakhq[bot] merged 1 commit intomainfrom Sep 28, 2022
Merged
fix: Streaming to destination plugin wasn't implemented correctly#187kodiakhq[bot] merged 1 commit intomainfrom
kodiakhq[bot] merged 1 commit intomainfrom
Conversation
We need to call CloseAndRecv on the client side and CloseAndSend on Server side for everything to close gracefully. This should help with places where data wasn't written because the connection was closed before everything was written to database.
19fa6c6 to
9d1f71b
Compare
shimonp21
approved these changes
Sep 28, 2022
shimonp21
pushed a commit
that referenced
this pull request
Sep 28, 2022
🤖 I have created a release *beep* *boop* --- ## [0.10.2](v0.10.1...v0.10.2) (2022-09-28) ### Bug Fixes * Streaming to destination plugin wasn't implemented correctly ([#187](#187)) ([8e28bd1](8e28bd1)) * Validate versions only for github registry ([#188](#188)) ([7f9a3ba](7f9a3ba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to call CloseAndRecv on the client side and CloseAndSend on Server side for everything to close gracefully.
This should help with places where data wasn't written because the connection was closed before everything was written to database.
https://github.com/grpc/grpc-go/blob/master/examples/route_guide/client/client.go