feat: Add PermissionsNeeded to tables schema
#1827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b550c45 to
1d4b1b1
Compare
marianogappa
approved these changes
Jul 30, 2024
Contributor
marianogappa
left a comment
There was a problem hiding this comment.
Nothing prevents two different implementors from documenting the same cloud permissions differently 👀 it's just a string. I think it's fine, since it's just documentation.
| {Name: "incremental_key", Type: arrow.BinaryTypes.String, IncrementalKey: true}, | ||
| {Name: "multiple_attributes", Type: arrow.BinaryTypes.String, PrimaryKey: true, IncrementalKey: true, NotNull: true, Unique: true}, | ||
| }, | ||
| PermissionsNeeded: []string{"storage.buckets.list"}, |
Contributor
There was a problem hiding this comment.
I guess the only other feature than a literal documentation string is the fact that commas are a special character; do you want to check that the splitting is maintained when you go back and forth?
Member
Author
There was a problem hiding this comment.
Ah good point let me handle that
5 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
#### Summary Follow up to #1827 (comment) ---
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
🤖 I have created a release *beep* *boop* --- ## [4.55.0](v4.54.0...v4.55.0) (2024-07-30) ### Features * Add `PermissionsNeeded` to tables schema ([#1827](#1827)) ([863b906](863b906)) ### Bug Fixes * Handle commas in permissions array ([#1835](#1835)) ([b633aed](b633aed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://github.com/cloudquery/cloudquery-issues/issues/2034 needs cloudquery/cloudquery-api-go#205
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)