fix: Account for bytes limit properly when batching records for writing #1719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
reviewed
Jun 5, 2024
candiduslynx
added a commit
that referenced
this pull request
Jun 5, 2024
candiduslynx
commented
Jun 6, 2024
⏱️ Benchmark results
|
1 task
erezrokah
reviewed
Jun 17, 2024
erezrokah
reviewed
Jun 17, 2024
dc709ed to
4b1ff8a
Compare
reset limit only when needed no extra loops
4b1ff8a to
0c8510e
Compare
erezrokah
approved these changes
Jun 20, 2024
Member
|
🚢 |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
🤖 I have created a release *beep* *boop* --- ## [4.45.6](v4.45.5...v4.45.6) (2024-06-20) ### Bug Fixes * Account for bytes limit properly when batching records for writing ([#1719](#1719)) ([25e554e](25e554e)) * **deps:** Update dependency go to v1.21.11 ([#1752](#1752)) ([abcb2d4](abcb2d4)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.20.2 ([#1754](#1754)) ([6288710](6288710)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cloudquery/cloudquery-issues/issues/1567
Fixes https://github.com/cloudquery/cloudquery-issues/issues/1655
The new
batchpackage provides a reusable logic for batching, accounting both for the bytes & rows limits.