feat: Addition and hopefully soon removal of gen command#169
Closed
yevgenypats wants to merge 1 commit intomainfrom
Closed
feat: Addition and hopefully soon removal of gen command#169yevgenypats wants to merge 1 commit intomainfrom
yevgenypats wants to merge 1 commit intomainfrom
Conversation
yevgenypats
added a commit
to cloudquery/cloudquery
that referenced
this pull request
Sep 22, 2022
See more details cloudquery/plugin-sdk#169
yevgenypats
added a commit
to cloudquery/cloudquery
that referenced
this pull request
Sep 22, 2022
See more details cloudquery/plugin-sdk#169
Contributor
|
Agree, let's drop the |
Contributor
|
So if all agree then this PR will be closed, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was working on fixing bugs in the gen command, moving it to the SDK (from the CLI after moving it from from the SDK 2 two weeks ago :) , protocol changes, tests, templates), adding flags to the gen command (testing the gen command) I realised once again that we are slowly becoming a yaml automation company (https://xkcd.com/1319/) and now we have to make sure the "example config" that our baked cli example config should be up to date with the non-existent documentation (which is actually more important then the baked gen command).
I believe we should drop the gen command as there is very little difference or time saving between the following:
vs
create those two files
I believe we should stop maintaing this command before releasing v2 pre-release and maintain this public api as we can put our effort in better places by providing up-to-date documentation and consistent behaviour.
Also, a bit more context on defaults:
if plugins have defaults this can work with the above small files as we shouldn't create defaults by saving those into a string and then outputing them back into a file and reading them back to the spec :)